Open
Conversation
Rename 12 test functions to follow the Test_StructName_FunctionName and Test_FunctionName naming convention. Document the convention in MAINTAINERS_GUIDE.md and CLAUDE.md.
Reorder test functions added on this branch alphabetically within their files, grouping getter/setter tests under the base name. Document the test ordering convention in MAINTAINERS_GUIDE.md and CLAUDE.md.
mwbrooks
added
code health
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
==========================================
+ Coverage 67.88% 68.24% +0.35%
==========================================
Files 218 218
Lines 18090 18090
==========================================
+ Hits 12281 12345 +64
+ Misses 4654 4587 -67
- Partials 1155 1158 +3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mwbrooks
commented
Mar 12, 2026
Member
Author
mwbrooks
left a comment
mwbrooks
left a comment
There was a problem hiding this comment.
Comments for the patient reviewers! 🔖
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func Test_IOStreams_ExitCode(t *testing.T) { |
Member
Author
There was a problem hiding this comment.
note: Alphabetically ordered as best as we can. 🔤
| - Mock the `ClientFactory` and its dependencies for testing | ||
| - Always mock file system operations using `afero.Fs` to enable testability | ||
|
|
||
| ### Test Naming Conventions |
Member
Author
There was a problem hiding this comment.
note: Helping Claude be better 💪🏻
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog
Summary
This pull request increases the test coverage of our
package iostreamsand brings our total coverage to 68.24% (+0.35%).CLAUDE.mddocumentation on test case naming and orderingRequirements